summaryrefslogtreecommitdiffstats
path: root/HACKING
diff options
context:
space:
mode:
authorAndrew Gregory <andrew.gregory.8@gmail.com>2013-05-18 19:37:59 -0400
committerAllan McRae <allan@archlinux.org>2013-05-29 14:08:03 +1000
commite5dd8c2ac561173c93849c4baab6be2406679be5 (patch)
treef948be5fe0b54e33d678e11b18bcb19eefe53cd4 /HACKING
parent5bcc058d4217a3e843e9adfbe0d8882ddf0f31b1 (diff)
downloadpacman-e5dd8c2ac561173c93849c4baab6be2406679be5.tar.xz
add.c: refactor backup file modification checks
The previous implementation was overly complex with unnecessary checks and nested conditionals. By reordering the tests and changing them to all be checks for positive hash matches rather than non-matches, we can collapse several cases and make the process much more linear. This removes the need to set hash_orig = "" just to reach some of the checks and corrects a faulty assumption that files are equivalent when the hashing process fails. Signed-off-by: Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by: Allan McRae <allan@archlinux.org>
Diffstat (limited to 'HACKING')
0 files changed, 0 insertions, 0 deletions