summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAllan McRae <allan@archlinux.org>2013-07-21 20:00:11 +1000
committerAllan McRae <allan@archlinux.org>2013-10-15 12:40:53 +1000
commited511b141f1680b52efe3338eb90a9598af0a4dd (patch)
treef24581c136ba1c890154f4cfbc81eb9f87f8cb51
parente5f23e0ebb14be22623c38130e6c2b3c37954a2b (diff)
downloadpacman-ed511b141f1680b52efe3338eb90a9598af0a4dd.tar.xz
Report which package is missing a signature
If any package in a sync transaction is missing a required signature, we give an uninformative error message (which may or may not state that the missing signature is the issue). Always output the package with the missing signature. Signed-off-by: Allan McRae <allan@archlinux.org>
-rw-r--r--lib/libalpm/sync.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/lib/libalpm/sync.c b/lib/libalpm/sync.c
index 98c0bc1d..0d01a5af 100644
--- a/lib/libalpm/sync.c
+++ b/lib/libalpm/sync.c
@@ -1105,7 +1105,10 @@ static int check_validity(alpm_handle_t *handle,
if(errors) {
for(i = errors; i; i = i->next) {
struct validity *v = i->data;
- if(v->error == ALPM_ERR_PKG_INVALID_SIG) {
+ if(v->error == ALPM_ERR_PKG_MISSING_SIG) {
+ _alpm_log(handle, ALPM_LOG_ERROR,
+ _("%s: missing required signature\n"), v->pkg->name);
+ } else if(v->error == ALPM_ERR_PKG_INVALID_SIG) {
_alpm_process_siglist(handle, v->pkg->name, v->siglist,
v->level & ALPM_SIG_PACKAGE_OPTIONAL,
v->level & ALPM_SIG_PACKAGE_MARGINAL_OK,