diff options
| author | Allan McRae <allan@archlinux.org> | 2010-06-28 23:44:31 +1000 |
|---|---|---|
| committer | Dan McGee <dan@archlinux.org> | 2010-06-30 08:32:11 -0500 |
| commit | 081e6a83608a28516abb326c1f66a07b691e1a32 (patch) | |
| tree | f00be7ec4b086fd6aa4d684b192040fd2644f513 | |
| parent | 630e7508ee44f2c41ba3f5d17c0c9ac15b15af3b (diff) | |
| download | pacman-081e6a83608a28516abb326c1f66a07b691e1a32.tar.xz | |
Do not compare signed and unsigned types
The casting of nread is safe as it is tested to be >0 when it is
initally assigned. It is also being implicitly cast in the fwrite
call in the line above.
Signed-off-by: Allan McRae <allan@archlinux.org>
Signed-off-by: Dan McGee <dan@archlinux.org>
| -rw-r--r-- | lib/libalpm/dload.c | 2 | ||||
| -rw-r--r-- | src/pacman/pacman.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/lib/libalpm/dload.c b/lib/libalpm/dload.c index c11148d1..3185d2aa 100644 --- a/lib/libalpm/dload.c +++ b/lib/libalpm/dload.c @@ -251,7 +251,7 @@ static int download_internal(const char *url, const char *localpath, check_stop(); size_t nwritten = 0; nwritten = fwrite(buffer, 1, nread, localf); - if((nwritten != nread) || ferror(localf)) { + if((nwritten != (size_t)nread) || ferror(localf)) { pm_errno = PM_ERR_RETRIEVE; _alpm_log(PM_LOG_ERROR, _("error writing to file '%s': %s\n"), tempfile, strerror(errno)); diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 78407d67..a1b726dc 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -989,7 +989,7 @@ static int _parseconfig(const char *file, const char *givensection, file, linenum, value); break; default: - for(int gindex = 0; gindex < globbuf.gl_pathc; gindex++) { + for(size_t gindex = 0; gindex < globbuf.gl_pathc; gindex++) { pm_printf(PM_LOG_DEBUG, "config file %s, line %d: including %s\n", file, linenum, globbuf.gl_pathv[gindex]); _parseconfig(globbuf.gl_pathv[gindex], section, db); |