summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHolger Levsen <holger@layer-acht.org>2015-02-20 22:00:41 +0100
committerHolger Levsen <holger@layer-acht.org>2015-02-20 22:00:41 +0100
commitcd58038c9a8ca6ba9ef75b8d33ecbb7691ca5c36 (patch)
treebb733c3975d2d5644ed961ba7d57f94871af3cb5
parenta68ec2c77790d924974318c993c764d2f4b7b8bd (diff)
downloadjenkins.debian.net-cd58038c9a8ca6ba9ef75b8d33ecbb7691ca5c36.tar.xz
move another FIXME to TODO post jessie
-rw-r--r--TODO1
-rwxr-xr-xbin/g-i-installation.sh2
2 files changed, 2 insertions, 1 deletions
diff --git a/TODO b/TODO
index a1821cde..d3b797c9 100644
--- a/TODO
+++ b/TODO
@@ -38,6 +38,7 @@ See link:https://jenkins.debian.net/userContent/about.html["about jenkins.debian
* replace with bin/setsid.py workaround with setsid from the util-linux package from jessie
* etc/pbuilderrc: remove /run/shm bindmount once we are running jessie - this is a workaround for #700591
* bin/g-i-installation: use lvcreate without --virtualsize
+* check if the sudo workaround in bin/g-i-installation is still needed: 'guestmount -o uid=$(id -u) -o gid=$(id -g)' would be nicer, but it doesnt work: as root, the files seem to belong to jenkins, but as jenkins they cannot be accessed.
=== To be done once bugs are fixed
diff --git a/bin/g-i-installation.sh b/bin/g-i-installation.sh
index 9e45797e..ccb6fdb6 100755
--- a/bin/g-i-installation.sh
+++ b/bin/g-i-installation.sh
@@ -1189,7 +1189,7 @@ save_logs() {
SYSTEM_MNT=/media/$NAME
sudo mkdir -p $SYSTEM_MNT
FAILURE=false
- # FIXME: bugreport guestmount: -o uid doesnt work:
+ # workaround problem in guestmount in wheezy: -o uid doesnt work:
# "sudo guestmount -o uid=$(id -u) -o gid=$(id -g)" would be nicer, but it doesnt work: as root, the files seem to belong to jenkins, but as jenkins they cannot be accessed
sudo guestmount -a $LV -i --ro $SYSTEM_MNT || { echo "Warning: cannot mount filesystems from $LV" ; export FAILURE=true ; }
#