reproducible coreboot: only mention unreproducible images if there are some

2 files changed, 9 insertions, 1 deletions

diff --git a/TODO b/TODO
index a673b4b8..c94a86f4 100644
--- a/TODO
+++ b/TODO
@@ -248,6 +248,8 @@ egrep -R -l '(debbindiff had trouble comparing|maybe there is still )' /var/lib/
 *** CONFIG_PAYLOAD_GRUB2 is not set
 *** CONFIG_PAYLOAD_TIANOCORE is not set
 ** do bi-weekly runs
+** treat this job as one of the builder jobs? (=currently limited to 8)
+** libreboot ships images, verify those?
 
 * openwrt
 ** add credit for logo/artwork
@@ -256,6 +258,7 @@ egrep -R -l '(debbindiff had trouble comparing|maybe there is still )' /var/lib/
 ** build all packages? (set CONFIG_ALL=y and run 'make defconfig')
 ** file dbd bug about unable to inspect these .bin files
 ** do bi-weekly runs
+** treat this job as one of the builder jobs? (=currently limited to 8)
 
 * remote scheduling:
 ----
diff --git a/bin/reproducible_coreboot.sh b/bin/reproducible_coreboot.sh
index 5f672721..7f8418e2 100755
--- a/bin/reproducible_coreboot.sh
+++ b/bin/reproducible_coreboot.sh
@@ -264,7 +264,12 @@ write_page "       <h1>Reproducible Coreboot</h1>"
 write_page "       <p><em>Reproducible builds</em> enable anyone to reproduce bit by bit identical binary packages from a given source, so that anyone can verify that a given binary derived from the source it was said to be derived. There is a lot more information about <a href=\"https://wiki.debian.org/ReproducibleBuilds\">reproducible builds on the Debian wiki</a> and on <a href=\"https://reproducible.debian.net\">https://reproducible.debian.net</a>. The wiki has a lot more information, eg. why this is useful, what common issues exist and which workarounds and solutions are known.<br />"
 write_page "        <em>Reproducible Coreboot</em> is an effort to apply this to coreboot. Thus each coreboot.rom is build twice (without payloads), with a few varitations added and then those two ROMs are compared using <a href=\"https://tracker.debian.org/debbindiff\">debbindiff</a>. Please note that the toolchain is not varied at all as the rebuild happens on exactly the same system. More variations are expected to be seen in the wild.</p>"
 write_page "       <p>There is a monthly run <a href=\"https://jenkins.debian.net/view/reproducible/job/reproducible_coreboot/\">jenkins job</a> to test the <code>master</code> branch of <a href=\"https://review.coreboot.org/p/coreboot.git\">coreboot.git</a>. Currently this job is triggered more often though, because this is still under development and brand new. The jenkins job is simply running <a href=\"http://anonscm.debian.org/cgit/qa/jenkins.debian.net.git/tree/bin/reproducible_coreboot.sh\">reproducible_coreboot.sh</a> in a Debian environemnt and this script is solely responsible for creating this page. Feel invited to join <code>#debian-reproducible</code> (on irc.oftc.net) to request job runs whenever sensible. Patches and other <a href=\"mailto:reproducible-builds@lists.alioth.debian.org\">feedback</a> are very much appreciated!</p>"
-write_page "       <p>$GOOD_ROMS ($GOOD_PERCENT%) out of $ALL_ROMS built coreboot images were reproducible in our test setup, while $BAD_ROMS ($BAD_PERCENT%) failed to build from source."
+write_page "       <p>$GOOD_ROMS ($GOOD_PERCENT%) out of $ALL_ROMS built coreboot images were reproducible in our test setup"
+if [ "$GOOD_PERCENT" = "100.0" ] ; then
+	write_page "!"
+else
+	write_page ", while $BAD_ROMS ($BAD_PERCENT%) failed to build from source."
+fi
 write_page "        These tests were last run on $DATE for version ${COREBOOT_VERSION}.</p>"
 write_explaination_table coreboot
 cat $ROMS_HTML >> $PAGE