diff options
author | Michael J. Chudobiak <mjc@avtechpulse.com> | 2012-05-11 09:37:24 -0400 |
---|---|---|
committer | Vincent Untz <vuntz@gnome.org> | 2012-06-08 14:02:16 +0200 |
commit | a811d14893e4f1cae36a17c850585b6a8d16b1d0 (patch) | |
tree | 7eb6dab7b7104fe541dbe20f9e6e72046c87ff8f /thumbnail | |
parent | 266075cf62844ab639553c807de52ea9866f34b5 (diff) | |
download | xdg-specs-a811d14893e4f1cae36a17c850585b6a8d16b1d0.tar.xz |
thumbnail: Do not save failed thumbnails for unreadable images
https://bugs.freedesktop.org/show_bug.cgi?id=49799
See http://lists.freedesktop.org/archives/xdg/2012-May/012398.html
Diffstat (limited to 'thumbnail')
-rw-r--r-- | thumbnail/thumbnail-spec.sgml | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/thumbnail/thumbnail-spec.sgml b/thumbnail/thumbnail-spec.sgml index cc6c70c..d142e95 100644 --- a/thumbnail/thumbnail-spec.sgml +++ b/thumbnail/thumbnail-spec.sgml @@ -467,6 +467,12 @@ $XDG_CACHE_HOME/thumbnails/fail/ way we assure that if a user creates a thumbnail for a file where only he has read-permissions no other user can take a glance on it through the backdoor with the thumbnails.</para> + + <para>Programs should first check that the original image file is readable. + If it is not, the program should not attempt to read a thumbnail from the + cache, and it should not save any information in the cache (including + "failed" thumbnails). Otherwise, thumbnailing will be prevented even if the + permissions are changed to permit reading.</para> </sect2> <sect2><title>Concurrent Thumbnail Creation</title> <para>An important goal @@ -608,7 +614,7 @@ if (file.mtime != thumb.MTime) { with the name of the program appended by the version number (eg. <prompt>$XDG_CACHE_HOME/thumbnails/fail/nautilus-1.0</prompt>).</para> - <para> For every thumbnail generation failure the program creates an empty + <para> For every thumbnail generation failure of a readable image, the program creates an empty PNG file. If it's possible to obtain some additional information from the image (see <link linkend="addinfos">Store Additional Information</link>) they should be stored together with the thumbnail |