From d060e31be3586ce27382f80eaed7a9edf2c86aeb Mon Sep 17 00:00:00 2001 From: Nagy Gabor Date: Mon, 10 Mar 2008 15:38:08 +0100 Subject: Remove trans->targets Its implementation was quite broken: * add_loadtarget() might have silently filtered out some targets when replacing an older version. * This was used in sync.c to determine whether a target is implicit or not, which is incorrect behavior. Before this patch we silently removed user confirmed replacements; now we always warn on a replacement. * remove001.py behavior was quite odd in adding same target 5 times to the target list, we can change this behavior to be a failure. Signed-off-by: Nagy Gabor [Xav: changed remove001 pactest accordingly] Signed-off-by: Chantry Xavier [Dan: rewrote commit message] Signed-off-by: Dan McGee --- lib/libalpm/add.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/libalpm/add.c') diff --git a/lib/libalpm/add.c b/lib/libalpm/add.c index 6c0a1eae..4d8e1a03 100644 --- a/lib/libalpm/add.c +++ b/lib/libalpm/add.c @@ -848,7 +848,7 @@ int _alpm_add_commit(pmtrans_t *trans, pmdb_t *db) return(0); } - pkg_count = alpm_list_count(trans->targets); + pkg_count = alpm_list_count(trans->packages); pkg_current = 1; /* loop through our package list adding/upgrading one at a time */ -- cgit v1.2.3-54-g00ecf