summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2007-07-06Various small fixes as suggested by some static code checkersDan McGee4-14/+7
I ran flawfinder and sparse over the pacman source code and found a few things that were worth fixing (and were quick fixes). Signed-off-by: Dan McGee <dan@archlinux.org>
2007-07-06Fix up pactest TODODan McGee1-1/+1
Signed-off-by: Dan McGee <dan@archlinux.org>
2007-07-02Reduce delay in pactest when running MODIFIED testsDan McGee1-4/+2
pactest was sleeping for 3 seconds, which is unnecessary. Reduce it to 1.5 seconds and clean up the code a bit anyway. Signed-off-by: Dan McGee <dan@archlinux.org>
2007-07-02pacman/query.c : return after a query on all packages.Chantry Xavier1-0/+1
Previously, the following error was displayed even after a valid and successful query operation on all packages, like -Q , -Ql, -Qi, -Qil : no targets specified (use -h for help) Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
2007-07-01Update 'submitting-patches'Dan McGee1-4/+16
Signed-off-by: Dan McGee <dan@archlinux.org>
2007-07-01pacman/packages.c : print an error for files that can't be stated.Chantry Xavier1-3/+8
The -Ql operation is supposed to print all files but directories. stat was used for detecting directories. However, when stat failed, (because the file doesn't exist or is not readable), the files were still displayed just like the others. Now, these files are printed on stderr, with the corresponding error message. Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
2007-07-01libalpm/add.c : fix for FS #7484Chantry Xavier1-1/+9
Adds the ARCHIVE_EXTRACT_NO_OVERWRITE libarchive flags for extracting files and directories. This will prevent symlinks for being overwritten by directories. All other files that need to be extracted should already have been deleted previously by pacman. This flag is not used for extracting files in backup array to /tmp/alpm_XXXX, because this file is created by mkstemp first, and so needs to be overwritten by the file from the archive. Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
2007-07-01libalpm/add.c,util.c : log ARCHIVE_WARN warning to debug output.Chantry Xavier2-6/+23
Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
2007-07-01Remove unnecessary and extra includesDan McGee4-17/+0
Signed-off-by: Dan McGee <dan@archlinux.org>
2007-07-01Add mode and type checking to pactest for filesDan McGee3-16/+54
Add the ability to check the permissions and type of a file within the framework of pactest. Two new rules can be used: self.addrule("FILE_TYPE=bin/foo|file") self.addrule("FILE_MODE=bin/bar|644") TODO: add the ability to add different types of files (eg links) via the test package building framework, and add the ability to change the modes on files. Signed-off-by: Dan McGee <dan@archlinux.org>
2007-07-01Move Doxygen manpage generation to doc/ directoryDan McGee3-32/+12
Instead of doing the doxygen work in the libalpm/ dir, do it with the rest of the docs in the doc/ dir. Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-28libalpm/add.c : ignore libarchive warning.Chantry Xavier1-6/+11
With libarchive 2.2.3 (previously 1.3.1), archive_read_extract now returns ARCHIVE_WARN when a package is extracted as user, because for example, UID=0 or SUID bit can't be set. This patch makes pacman not treating these warnings as errors anymore, but simply ignoring them. Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
2007-06-28libalpm/util.c : stat returns 0 on successChantry Xavier1-1/+1
Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
2007-06-28scripts/makepkg.in: Don't include .PKGINFO etc in .FILELISTAndrew Fyfe1-4/+7
And move .PKGINFO and .FILELIST to be the first to files included in the package. Signed-off-by: Andrew Fyfe <andrew@neptune-one.net>
2007-06-27Remove lockfile configuration from frontend, make it job of libalpmDan McGee11-40/+15
I previously introduced some patches to make just about every path in pacman/libalpm configurable; doing this with the lockfile seemed a bit too far and we really should just place the lockfile where it belongs- with the DB that needs locking. More details in this thread: http://archlinux.org/pipermail/pacman-dev/2007-June/008499.html Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-27pacman.c: make parseconfig a bit more robustDan McGee1-12/+21
Don't let parseconfig overwrite settings that parseargs already made. Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-27Remove scriptlet START and DONE commands that we don't useDan McGee4-53/+1
The scriptlet calling had some unneeded complexity for the time being which we aren't using here. Let's get rid of it until we find a good way to implement it correctly. Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-27scripts/makepkg.in: Use bsdtar to find packages for xdelta.Andrew Fyfe1-9/+10
When looking for old packages to create a delta from used bsdtar to read the packages .PKGINFO to check it's name and arch instead of depending on the filename of th package. Signed-off-by: Andrew Fyfe <andrew@neptune-one.net>
2007-06-27scripts/makepkg.in: Fix creation of .FILELISTChantry Xavier1-1/+2
Signed-off-by: Andrew Fyfe <andrew@neptune-one.net>
2007-06-27FS7485: Replace tar/cpio/unzip with bsdtar for extracting/creating packages.Baptiste Daroussin1-17/+5
Signed-off-by: Andrew Fyfe <andrew@neptune-one.net>
2007-06-27Fix wrong permissions on pacnew extractionDan McGee1-0/+15
First reported here: http://bbs.archlinux.org/viewtopic.php?pid=261861 Newly created files were done with the standard umask, so those that are extracted seperately and copied to a .pacnew extension will have the wrong permissions. This should hopefully fix this. Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-27Remove TODO items that have been taken care of.Dan McGee2-33/+0
Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-28libalpm/remove.c : file variable used before being initialized.Chantry Xavier1-1/+2
Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
2007-06-27Add archlinux.de mirrorDan McGee1-0/+1
Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-26Add pactest to help debug FS #7415Chantry Xavier1-0/+22
Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-26Add sync301 pactest- pacman gains new deps and should be pulled inChantry Xavier1-0/+25
Signed-off-by: Chantry Xavier <shiningxc@gmail.com> Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-26Make alpm_splitdep immutableNagy Gabor1-5/+9
The alpm_splitdep function formerly overwrote the input string, causing a few issues. Fix this. Signed-off-by: Nagy Gabor <ngaba@petra.hos.u-szeged.hu> Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-26Remove unnecessary trans parameter from _alpm_checkdepsNagy Gabor5-9/+8
The trans parameter was never used, so remove it. Signed-off-by: Nagy Gabor <ngaba@petra.hos.u-szeged.hu> Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-26Don't extract any top-level files in a package that start with '.'Dan McGee1-1/+8
For future possibilities, don't extract any files that start with '.'. This will allow us to add features such as the ChangeLog viewing without having to wait to include these files in packages, because older versions of pacman will be forward compatable with 'hidden' files at the root level of the package. Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-26Mirror update and NEWS updatesDan McGee2-0/+13
Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-20libalpm/util.c: remove unnecessary includeDan McGee1-1/+0
Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-20Revert "Fix libarchive permission extraction"Dan McGee1-2/+0
This was a bad way to fix a problem upstream. Doing this resulted in symlink permissions being applied to files installed on the system, leaving some binaries with 77 permission, etc. This reverts commit 4e6b7c1cde4c0ac1d035b51f9af19510a7c9135e.
2007-06-17Update Doxyfile and add a few missing parts of documentationDan McGee2-1/+26
Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-17Remove some use of goto in the pacman frontendDan McGee2-30/+48
Refactor the goto cleanup; statements out of add.c and remove.c, and move what the cleanup: label did into a function. Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-17Quick updates to the bash completion scriptDan McGee1-16/+9
Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-17FS7338: Fix conflicts typo totally this time.Chantry Xavier1-1/+1
The last typo fix for conflicts wasn't complete, it only fixed one occurence of the conflicts variable, instead of the two : http://www.archlinux.org/pipermail/pacman-dev/2007-May/008222.html This caused all conflicts statement to be ignored, so all databases will need to be rebuilt with a fixed repo-add. Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
2007-06-13scripts/makepkg.in: Forgot the fakeroot switch when changing to GNU getopt.Andrew Fyfe1-2/+3
Signed-off-by: Andrew Fyfe <andrew@neptune-one.net>
2007-06-13Add ARM architecture to configure.acDan McGee1-0/+5
Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-13Clean up pacman/sync.c and organize it a bitDan McGee2-11/+40
Re-add some checks for a valid target list. In addition, move variable declarations to the most local scope possible, which should help in finding errors that were previously uncaught. Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-13Remove some more diskspace checking holdover stuffDan McGee4-27/+3
Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-12Functionalize query.c and pacman_queryDan McGee1-111/+168
Move a lot of the operations that pacman query performs into their own functions for ease of following the flow and for possible later merges with their sync counterparts. We need to think less in terms of operations and more in term of overall concepts. Also (re)introduced checks for the target list on a -Q operation, ensuring that we only call certain query operations when it is sane to do so. Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-12scripts/makepkg.in: Added fakeroot version to .PKGINFO header.Andrew Fyfe1-0/+3
Signed-off-by: Andrew Fyfe <andrew@neptune-one.net>
2007-06-12scripts/makepkg.in: Switch to GNU getopt.Andrew Fyfe1-81/+45
Signed-off-by: Andrew Fyfe <andrew@neptune-one.net>
2007-06-12Add pactest requiredby004.Nagy Gabor1-0/+20
Upgrade a package that no longer needs a depend. Reference: http://www.archlinux.org/pipermail/pacman-dev/2007-June/008503.html Signed-off-by: Chantry Xavier <shiningxc@gmail.com> Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-12pacman util.h: Add missing stdarg.h includeDan McGee1-0/+1
Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-11FS7355: Add --ignorearch option to makepkgAndreas Hauser1-5/+16
Signed-off-by: Andrew Fyfe <andrew@neptune-one.net> Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-11Add new pactest remove043.Nagy Gabor1-0/+18
Remove a package required by another package. Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
2007-06-10Attempt to clean up _alpm_sync_prepareDan McGee1-64/+56
This function is an absolute disaster, so we'll take it one step at a time here. This was a quick once-over of the whole thing, trying to straighten out some of the spaghetti code and fix some mistakes that others found. We are now down to two failing pactests again: sync300 and upgrade051. Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-10Implement simple topological sort algorithm for sortbydepsNagy Gabor5-59/+95
Based on the "depth first search" algorithm, for more infos visit: http://en.wikipedia.org/wiki/Topological_sorting The previous algorithm used by sortbydeps was too slow, and to work around it the number of steps needed to get correct result was reduced greatly. So it produced wrong results in several cases : 1) smoke001.py 2) http://bugs.archlinux.org/task/7229 More here: http://archlinux.org/pipermail/pacman-dev/2007-April/008057.html Signed-off-by: Chantry Xavier <shiningxc@gmail.com> Signed-off-by: Dan McGee <dan@archlinux.org>
2007-06-10Ensure correct and consistent usage of depmissChantry Xavier5-58/+22
See comment from Nagy here : http://www.archlinux.org/pipermail/pacman-dev/2007-April/008134.html This also makes easier correct usage of checkdeps in sync.c, which fixes sync901 pactest (and so bug 6057). Signed-off-by: Dan McGee <dan@archlinux.org>