summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2008-01-13Disallow a NULL section in _parseconfigDan McGee1-2/+2
If we allow _parseconfig to continue processing when section is not defined, then we have the potential to segfault during strcmp calls. This is no good. For some reason, we had existing logic that tested this case but only if it was processing and 'Include' directive. Expand the check to check for a NULL section in all cases, and print an error message if this is the case. Reported here: http://bbs.archlinux.org/viewtopic.php?id=42235 Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-13Ensure correct dir permissions in the database.Chantry Xavier2-0/+5
Fix for FS#9176. A previous commit (6e8daa553bbd5) already forced all database files to 644. Now the directories are also forced to 755. Additionally, repo-add now sets the umask to 022, just like makepkg does, to fix the problem at its root. Signed-off-by: Chantry Xavier <shiningxc@gmail.com> Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-13Merge branch 'maint'Dan McGee8-37/+39
2008-01-13Update Gensync and Updatesync to use new PKGEXT variableTravis Willard2-5/+5
Previously, this caused both scripts to look for pkgname-pkgver-pkgrel-arch..pkg.tar.gz - extra period has been removed. Fixes FS#9190. Signed-off-by: Travis Willard <travis@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-13Notify of package replacements when using noconfirmAllan McRae1-5/+13
Fixes FS#5179. Prints a notification of package replacements when updating the packages using the --noconfirm flag. Signed-off-by: Allan McRae <mcrae_allan@hotmail.com> Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-13zsh_completion : minor fixes.Chantry Xavier1-15/+5
-Qg was handled twice. --ignore completed on all installed packages instead of all packages. --ignoregroup had a special handling that seems unnecessary. It wasn't done for --ignore, and it apparently works fine without anyway. Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
2008-01-13util.c : fix segfault when the cachedir isn't usable.Chantry Xavier1-2/+0
For example, if the cachedir is a broken symlink or a non writable directory, pacman fallbacks to /tmp/. Just before doing that, it freed the handle->cachedirs list twice ! once in _alpm_filecache_setup, and once in alpm_option_set_cachedirs. So the first one was removed. Fixes FS#9186. Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
2008-01-13Fix cvsmod typo in PKGBUILD man page.Chantry Xavier1-1/+1
Fixes FS#9175. Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
2008-01-12memleak fix with new dynamic depend structureDan McGee1-1/+1
Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-12libalpm/sync.c: don't duplicate packages for the sync->data field.Chantry Xavier1-35/+7
Packages put in the sync->data field were always duplicated with pkg_dup, and then freed, This is not needed. Killing this duplication of packages made the memory usage during base reinstall go from 10.4 MB to 8.1 MB. Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
2008-01-12small checkdeps speed-upNagy Gabor1-8/+12
In the old code 'alpm_list_diff(_alpm_db_get_pkgcache(db), dblist, _alpm_pkg_cmp);' was slow. Signed-off-by: Nagy Gabor <ngaba@bibl.u-szeged.hu> [Xav: In my opinion, computing both dblist and modified in one for loop also makes the code clearer, besides being more efficient. Also renamed joined to targets since I also find that clearer.] Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
2008-01-12don't send CHECKDEPS_DONE event when NODEPS is set.Chantry Xavier1-1/+3
Signed-off-by: Chantry Xavier <shiningxc@gmail.com> Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-12Store replaces in the local DB tooAaron Griffin1-28/+9
Signed-off-by: Aaron Griffin <aaronmgriffin@gmail.com> [Dan: might as well store 'force' too] Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-11Merge branch 'maint'Dan McGee7-13/+27
2008-01-11New reason001.py pactestNagy Gabor1-0/+16
This pactest demonstrates that we should copy the reason between the to-be-replaced and replaced packages Signed-off-by: Nagy Gabor <ngaba@bibl.u-szeged.hu> Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-11Add functions to manipulate pmdepend_t objectsDan McGee3-28/+44
We didn't have a free function before, causing some memory leaks. We also need a dup function now that strings are not in the structure but are dynamically allocated. Also adapt pmdepmissing_t to use a pointer to a depend struct instead of an inclusive one so we can use the functions we created here. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-11extends valgrind.supp and adds quick instructions.Chantry Xavier1-1/+17
Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
2008-01-11Only notify of dependency check in removal if performedAllan McRae1-2/+2
Moves "checking dependencies..." notification into code block where dependency checking is performed to stop spurious notification. Reference: http://archlinux.org/pipermail/pacman-dev/2008-January/010714.html Signed-off-by: Allan McRae <mcrae_allan@hotmail.com> Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-11Make the user-agent string a bit less verboseDan McGee1-4/+2
We shouldn't pass things like the kernel version in the user agent string, as it may be a bit too revealing and is not really necessary. Reference: https://bugzilla.mozilla.org/show_bug.cgi?id=57555 Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-11Fix library interfaceDan McGee4-6/+6
Two functions defined in alpm.h were not marked with SYMEXPORT, causing linking errors if they were used. In addition, remove the incorrect use of the 'alpm_' prefix from an internal function and replace it with '_alpm_'. Fixes FS#9155. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-11Use dynamic string allocation in package structuresDan McGee14-203/+288
This also affects all structures with static strings, such as depmiss, conflict, etc. This should help a lot with memory usage, and hopefully make things a bit more "idiot proof". Currently our pactest pass/fail rate is identical before and after this patch. This is not to say it is a perfect patch- I have yet to pull valgrind out. However, this should be quite safe to use in all situations from here on out, and we can start plugging the memleaks. Original-work-by: Aaron Griffin <aaronmgriffin@gmail.com> Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-10Output a single newline on receipt of a SIGINTDan McGee1-5/+6
Fixes FS#9147, where issuing a ctrl-C at a prompt puts the users prompt on the same line as our question. This can also occur during download bars. Although we might end up putting one too many newlines to the screen now, it is better than not putting one at all. Also update the copyright in pacman.c. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-10doc: add note to pacman.conf manpage explaining $repoDan McGee1-5/+26
Fixes FS#9142. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-10doc: add info about optdependsDan McGee1-0/+9
Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-10Rename -t --orphans to -t --unrequired (FS#9144).Chantry Xavier6-16/+10
It turns out the orphan name was misleading. Real orphans are packages installed as dependency no longer required by any others (-Qtd). The -t option only shows package not required by any others, so --unrequired describes it better. Signed-off-by: Chantry Xavier <shiningxc@gmail.com> Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-10Bump version to develDan McGee1-2/+2
Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-09makepkg: Ensure we include all manpage directories in compression lineDan McGee1-1/+1
Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-09Move the fallback on providers from backend to frontend.Chantry Xavier3-29/+48
This reverts commit e28973169d2e5eda8b64ebdda11ece0dc761d978. This code might fit better in the frontend than in the backend finally. Ref: http://www.archlinux.org/pipermail/pacman-dev/2007-November/010150.html I also changed it for fixing FS#8763 : if there is exactly one provider, pacman will pull it and print a warning. if there are several providers, pacman will list them and fail. It's up to the user to pick one. Add sync501 pactest to reflect that.
2008-01-09makepkg: add package name to output when installing packageKarolina Lindqvist1-2/+1
Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-09Update configure.ac version for releaseDan McGee1-1/+1
Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-08Documentation updatesNathan Jones1-6/+19
Document the following: * -R can take a group * -S can take a group and provision I also split up the -S description into multiple paragraphs because it was getting too large. Signed-off-by: Nathan Jones <nathanj@insightbb.com> [Dan: added some feedback from the ML, rewrapped lines] Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-08NEWS: fix note about ABSDan McGee1-1/+1
Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-08Remove upgradedelay and all code associated with itDan McGee7-48/+0
It wasn't even implemented correctly, and it really doesn't have a use if packagers just do their job correctly anyway for a distro. Let's not try to solve a problem with the wrong solution now. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-08Remove unused date element from pmpkg_t structDan McGee2-3/+3
We had an unused date element in the pmpkg_t struct (not builddate or installdate). Kill it off and fix the one function that was using it. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-08Update NEWS with versioned conflicts and new DEP_MOD operators.Chantry Xavier1-0/+2
Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
2008-01-08makepkg: Fix issues with --asroot and building dependenciesDan McGee1-3/+4
The --asroot option was not passed to recursive calls of makepkg. In addition, a 'cd' call was done only on the fakeroot branch instead of both fakeroot and root branches. Move it outside the conditional. Noticed-by: Karolina Lindqvist <karolina.lindqvist@kramnet.se> Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-07Update translation-help with new translation policiesDan McGee1-30/+86
Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-06Documentation updatesDan McGee2-14/+31
Update description of path specifiers for both pacman and pacman.conf in their respective manpages. Ensure it is obvious that they are absolute and not relative paths. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-06Asciidoc a few more of our informative filesDan McGee3-67/+97
Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-06Remove makeworld from pacman packageDan McGee4-199/+0
This is an Arch-specific tool (although others could find use in it), so off to the standalone ABS package it goes. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-06Remove stuff that was a little too Arch-specific from manpage footerDan McGee1-4/+3
Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-06install: install prototype PKGBUILD and install to datadirDan McGee5-5/+4
Move the prototypes out of contrib/ and into the top level directory, and install them to what is usually /usr/share/pacman/ on a package install. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-06Remove hardcoded DBEXT value from scriptDan McGee2-3/+4
Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-06conflict.c : fix for FS#8156, detect conflict between symlink and dir.Chantry Xavier2-5/+30
The previous fileconflict check (package vs filesystem) skipped the conflict when the file on the filesystem was a directory or a symlink to a directory, no matter what the file in the package was. Now, the conflict will only be skipped if the file in the package is a directory (so compatible with a dir or a dir symlink on the filesystem). So in the case of 8156 (new fileconflict003 pactest for this case), instead of silently ignoring the extraction of the test symlink, pacman will now fail because of a file conflict between the test symlink in the pkg2 package and the test directory on the filesystem. Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
2008-01-06bugfix in pactest when creating a symlink at the top level.Chantry Xavier1-1/+2
Trying to make a symlink at the top level previously made pactest fail. For example : "test -> test2/" as a file in a package. The path to the test symlink was empty in this case, but the python code still tried to chdir in "", which failed. Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
2008-01-05Don't stat cachedir immediatelyDan McGee2-8/+3
By attempting to stat the cachedir when we load the pacman config, pacman bails out if it is a non-existant directory, even if it will never be needed. This is unfortunate as it is only used for sync transactions anyway. Instead, wait until we need it in _alpm_filecache_setup to actually do anything. Reported as FS#9096. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-05sync.c: add sanity check so we don't dereference a null pointerDan McGee2-6/+34
Originally noticed in FS#9024, but was fixed in previous changes anyway. However, it doesn't hurt to still check it. Also add a pactest from Chantry Xavier for the original problem to ensure we can't reproduce it. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-05conflict.c : fix for upgrade042.Chantry Xavier2-17/+35
Thanks to the proactive backup handling, we don't need to add the moving file to the skip_add list. The backup handling will make sure nothing gets overwritten. Ref: http://www.archlinux.org/pipermail/pacman-dev/2007-December/010610.html Signed-off-by: Chantry Xavier <shiningxc@gmail.com> Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-05makepkg: add application/zip to the recognized typesDan McGee1-1/+1
The recent upgrade of magic.mime in the file program changed the mime type output to application/zip instead of application/x-zip as it is a registered type. Unfortunately we then just skipped zip file extraction becuase of this change. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-05scripts: extra exit() calls in usage() functionGustavo Chain2-2/+0
Remove the exit() calls from usage as they should be handled by the caller. Signed-off-by: Dan McGee <dan@archlinux.org>