summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2009-01-18Use archive_entry_set_perm instead of archive_entry_set_modeNagy Gabor2-4/+4
This patch fixes FS#12148 ('unstable' regular file). I also changed the other archive_entry_set_mode usage in add.c to archive_entry_set_perm. Since I cannot find any relevant info in libarchive manual, I quote Tim Kientzle (the author of libarchive) here, and I say thank you for his help. *** Tim Kientzle wrote ************************************* This is the problem in libalpm/util.c: 323 if(S_ISREG(st->st_mode)) { 324 archive_entry_set_mode(entry, 0644); 325 } else if(S_ISDIR(st->st_mode)) { 326 archive_entry_set_mode(entry, 0755); 327 } Your example unstable.db.tar.gz is not empty. It has one entry in it, called "./". That entry is marked as a directory. But, when you call archive_entry_set_mode(), you are changing the file type! archive_read_extract() then creates the file /var/unstable as you requested. (archive_read_extract() will replace an empty directory with a file.) You should either set the mode value correctly: 323 if(S_ISREG(st->st_mode)) { 324 archive_entry_set_mode(entry, IFREG | 0644); 325 } else if(S_ISDIR(st->st_mode)) { 326 archive_entry_set_mode(entry, IFDIR | 0755); 327 } Or use archive_entry_set_perm(), which does not change the file type: 323 if(S_ISREG(st->st_mode)) { 324 archive_entry_set_perm(entry, 0644); 325 } else if(S_ISDIR(st->st_mode)) { 326 archive_entry_set_perm(entry, 0755); 327 } ************************************************************ Signed-off-by: Nagy Gabor <ngaba@bibl.u-szeged.hu> Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-13doc: Consistency and formatting cleanupsDan McGee2-9/+9
Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-13doc: fix some more asciidoc falloutDan McGee2-6/+1
They keep changing things on us. This gets rid of the '.ft C' text sprinkled around our listing blocks. Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-11Fix linkman macro to work with asciidoc > 8.3.0Dan McGee1-0/+4
Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-05Update Czech translationVojtěch Gondžala2-266/+248
Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-05Update Portuguese (Brazil) translationHugo Doria1-23/+21
Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-04Update configure.ac for 3.2.2 releaseDan McGee1-2/+2
Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-04Update NEWS for 3.2.2Dan McGee1-0/+16
Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-03Update Polish translationMateusz Herych2-16/+13
Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-03Update Russian translationSergey Tereschenko1-8/+4
Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-03Update Turkish translationSamed Beyribey2-33/+29
Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-03Update Russian translationSergey Tereschenko2-29/+51
Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-03Update Unkranian translationRoman Kyrylych2-28/+33
Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-03Update Italian translationGiovanni Scafora2-133/+115
Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-03Update German translationMatthias Gorissen2-35/+18
Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-03Update Hungarian translationNagy Gabor1-18/+7
Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-03Update Chinese translation甘露(Gan Lu)1-118/+101
Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-03Update French translationXavier Chantry1-29/+12
Signed-off-by: Xavier Chantry <shiningxc@gmail.com>
2009-01-03Update Spanish translationJuan Pablo González Tognarelli2-79/+84
Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-02Separate local db directory creation and db writeAllan McRae3-3/+32
Changelogs and install files were getting extracted into the local db folder before it was manually created. This created issues for uses with 0077 umasks and was highlighted with the new sudo handling of umasks (FS#12263). This moves the local db creation to its own function which is called before the start of package archive extraction. Also, added a check that the folder is actually created. Signed-off-by: Allan McRae <allan@archlinux.org> [Dan: rename to _alpm_db_prepare()] Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-02Log pacsave warnings to pacman.logSterling Winter1-0/+1
Pacman currently logs .pacnew warnings to pacman.log but a similar history of .pacsave warnings isn't kept. The user should be able to search pacman.log to discover when and where all .pac* files were created by pacman. Addresses FS#12531. Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-02Add new po files in prep for 3.2.2 releaseDan McGee14-302/+623
Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-02Small makefile updateDan McGee1-1/+2
Use the proper call for symlink creation Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-02Fix asciidoc manpage creation.Xavier Chantry2-4/+4
As reported here, man pages could no longer be built : http://archlinux.org/pipermail/pacman-dev/2008-December/007726.html I found the explanation here : http://www.methods.co.nz/asciidoc/source-highlight-filter.html "If you use a2x(1) to generate PDF you need to include the --no-xmllint option to suppress xmllint(1) checking — the programlisting language attribute (required by the dblatex source highlighter) is not part of the DocBook 4 specification (but it is in the newer DocBook 5 specification)." Signed-off-by: Xavier Chantry <shiningxc@gmail.com> Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-02makepkg: detect incorrect usage of provides arrayAllan McRae2-3/+13
Using > or < in the provides array is wrong so make it cause an error. Fixes FS#12540. Also, use bash substitution rather than spawning new processes where possible in the error checking. Move split package detection to a better position. Signed-off-by: Allan McRae <allan@archlinux.org> [Dan: backport to maint] Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-02makepkg: tidy version package testsAllan McRae1-6/+6
The use if "! -z" to check if a string is not null is not good practice so replace with the "-n" option. Also use the AND comparison within one test rather than on two separate tests. Signed-off-by: Allan McRae <allan@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-02makepkg: quote all uses of BUILDSCRIPTAllan McRae1-4/+4
Allows specifying alternative build script with spaces in name Signed-off-by: Allan McRae <allan@archlinux.org> [Dan: backport some of the fixes to maint] Signed-off-by: Dan McGee <dan@archlinux.org>
2009-01-02makepkg: Replace getopt with internal functionAllan McRae1-2/+89
This will allow makepkg to work on systems like Mac OS X where the default getopt is too old to properly handle long options. The new parse_options function should replicate getopt's behaviour completely. Original work: Yun Zheng Hu <yunzheng.hu@gmail.com> [Allan: Rewrite and bug fixes] Signed-off-by: Allan McRae <allan@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
2008-12-10Print proxy information when downloadingDan McGee1-0/+6
May help debug issues we come across with proxy behavior (e.g. those pesky segfaults) as well as be informative to the user when things aren't working quite right. Addresses FS#12396. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-12-10Remove mention of -b from makepkg manpageDan McGee1-1/+1
Fixes FS#12408. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-12-07Small documentation updates for clarityDan McGee2-3/+3
Signed-off-by: Dan McGee <dan@archlinux.org>
2008-12-07makepkg: save and restore shell options before and after build()Dan McGee1-0/+4
Fix the issue uncovered by FS#12344. In this instance, the dotglob shopt was being set in the build() function but never cleared, causing issues in the remaining parts of the makepkg script. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-12-07contrib/pactree: fix option parsingAllan McRae1-2/+1
The option parsing was catching any "-d" in an argument so packages with this in their name did not work. Also removed commented code line that appears to be inserted during testing. Signed-off-by: Allan McRae <allan@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
2008-12-02Add optdepends to PKGBUILD.protoAllan McRae1-0/+1
Signed-off-by: Allan McRae <allan@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
2008-12-02Add flush after downloading messageSimo Leone1-0/+1
When the output is going to a file, glibc seems to buffer way too much making it hard to monitor progress while tailing a file. Signed-off-by: Simo Leone <simo@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
2008-11-30Add regex to delta code so we don't segfault when reading lineDan McGee2-1/+19
If the delta line doesn't match our regex, we won't go and process it, possibly walking off the end of the string. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-11-30Give an error message on alpm_db_register_sync() errorNagy Gabor1-12/+34
This patch slightly modifies pacman.c/_parseconfig(): See FS#12148. Now pacman prints the following error message in that case: "error: could not register 'unstable' database (could not open database)" I also added an error message for alpm_db_setserver() error. I changed the "return(1);" scheme to "ret = 1; goto cleanup;" to make sure that we free allocated memory and close open files. Signed-off-by: Nagy Gabor <ngaba@bibl.u-szeged.hu> Signed-off-by: Dan McGee <dan@archlinux.org>
2008-11-30Simplify mercurial revision commandDan McGee1-1/+1
Not only does this require less sed-magic, it also fixes FS#12286 where fetching the revision number fails if mercurial is in compact mode. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-11-17Minor code cleanupsDan McGee3-10/+9
Mostly noticed when compiling libalpm/pacman with ICC. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-10-31makepkg: fix bash substitution to work under older versionsDan McGee1-2/+2
Signed-off-by: Dan McGee <dan@archlinux.org>
2008-10-28Give pacman-optimize a refresherDan McGee1-21/+34
This patch addresses quite a few lingering issues in the pacman-optimize script. FS#11767 provoked this look-over and the following issues were noticed and fixed: * If an alternate dbroot was specified, then the lockfile location was never updated to reflect it. The lockfile location is now set after all dbpath initialization. * The inclusion of a trailing slash on dbroot was problematic and led to the following command being executed: bsdtar -xpf /tmp/pacman-optimize.p12Q4vAUWY/pacman-db.tar.gz \ -C /var/lib/pacman/.new/ It is doubtful we meant to create a hidden directory like this below our database root, only to go and delete it a second later and then re-extract. Fix the whole thing by ensuring our dbpath has its trailing slash stripped and then appending it when necessary. * The DB extraction was performed twice for no real apparent reason. This opens the door for extraction problems the second time around, leaving you with no original database to fall back to. Change the behavior so we only extract once, and then perform a directory shuffle once we verify the checksums are correct. * Perform an explicit sync after we drop the new database on the disk. It should work better this way. * Tighten up our check for a pacman lockfile and the time we create one. There is still a possible race condition but the window is shorter. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-10-28Update Chinese translationLyman Li2-227/+225
Signed-off-by: Dan McGee <dan@archlinux.org>
2008-10-28makepkg: fix updating PKGBUILD when building SCM packagesAllan McRae1-1/+3
Fixes a bug and resets pkgrel to 1 when bumping pkgver Signed-off-by: Allan McRae <allan@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
2008-10-18repo-add: Use openssl instead of md5sumDan McGee1-2/+2
This is similar to the change we made in makepkg so it is cross-platform compatible and doesn't require coreutils. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-10-18Correctly close the pipe used for scriptlet executionDan McGee1-3/+3
We never had a call to pclose() in here before, leaving our file descriptor in some sort of limbo state. In addition, clean up some of the other logic such as directly calling exit(1) on a popen() failure rather than going to our cleanup block, and handling and respecting the exit status of the subprocess correctly. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-10-12Minor updates to Russian translationSergey Tereschenko2-19/+19
Signed-off-by: Dan McGee <dan@archlinux.org>
2008-10-12Make interrupt handler async-safeDan McGee1-8/+22
Calling printf() in a signal handler can be dangerous, so avoid it by writing directly which is guaranteed to be safe according to signal(7). Signed-off-by: Dan McGee <dan@archlinux.org>
2008-10-12Remove unnecessary unistd.h header inclusionDan McGee4-4/+0
Signed-off-by: Dan McGee <dan@archlinux.org>
2008-10-12Attempt to idiot-proof making and refreshing docsDan McGee3-33/+15
I mess this up more often than not, and maybe this will do the trick. Remove the --enable-asciidoc option as it has been superseded by the --disable-doc option in usefulness. If you want to skip building docs, you skip building all docs which is much easier when it comes to ensuring the make 'dist' and 'distcheck' targets will always build the manpages and always build the most up to date manpages. Developers shouldn't be affected in their normal builds, nor should end users of the source tarball. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-10-12Rework fakechroot checkingDan McGee3-3/+9
Do the checks in the tests that need it, and get rid of some of the cluttered output when it is not available (one line per test run). Signed-off-by: Dan McGee <dan@archlinux.org>
generated by cgit v1.2.3-70-g09d2 (git 2.47.0) at 2024-11-27 01:55:01 +0000