diff options
author | Dave Reisner <dreisner@archlinux.org> | 2014-08-01 16:59:58 -0400 |
---|---|---|
committer | Allan McRae <allan@archlinux.org> | 2014-08-08 13:44:00 +1000 |
commit | cbd6c300b5bdf61b7df80f42cf06c69a6e4fde60 (patch) | |
tree | 9edc05923f66f75afedb7ef68faebd32d8724009 /test/scripts/Makefile.am | |
parent | 8d5d7f676196c9ec56dddc39de260eb40a51e843 (diff) | |
download | pacman-cbd6c300b5bdf61b7df80f42cf06c69a6e4fde60.tar.xz |
makepkg: refactor check_sanity, give it some sanity of its own
Break apart each of the blocks into their own separate functions. And,
instead of the hand crafted eval statements, reuse the logic from
pkgbuild-introspection[0] to abstract away the complexities of parsing
bash.
This commit fixes at least 3 bugs in check_sanity:
1) The wrong variable is shown for the error which would be thrown
when, e.g. pkgname=('foopkg' 'bar^pkg')
2) The "arch" variable is not sanity checked when the PKGBUILD has
an arch override, but only one output package.
3) https://bugs.archlinux.org/task/40361
Lastly, there's some string changes here which should help to clarify
a few errors emitted in the linting process.
[0] https://github.com/falconindy/pkgbuild-introspection
Diffstat (limited to 'test/scripts/Makefile.am')
0 files changed, 0 insertions, 0 deletions