summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHolger Levsen <holger@layer-acht.org>2015-05-14 14:53:01 +0200
committerHolger Levsen <holger@layer-acht.org>2015-05-14 14:53:01 +0200
commitbf60651182fa1484f3bc3aae9e575de3da4805c0 (patch)
tree5fd0f03adc44a58de41da59086bea0a187feaf82
parent19c8bc3bf374d52427c66fd8bc4db5b2909b3da0 (diff)
downloadjenkins.debian.net-bf60651182fa1484f3bc3aae9e575de3da4805c0.tar.xz
reproducible: explain and remove FIXME
-rwxr-xr-xbin/reproducible_html_graphs.sh5
1 files changed, 4 insertions, 1 deletions
diff --git a/bin/reproducible_html_graphs.sh b/bin/reproducible_html_graphs.sh
index 94da97f3..bcc4effa 100755
--- a/bin/reproducible_html_graphs.sh
+++ b/bin/reproducible_html_graphs.sh
@@ -180,6 +180,9 @@ gather_meta_stats() {
META_LIST=$(cat $PKGSET_PATH)
if [ ! -z "$META_LIST" ] ; then
META_WHERE=""
+ # gather data about all packages we know about
+ # as a result, unknown packages in the package set
+ # are silently ignored
for PKG in $META_LIST ; do
if [ -z "$META_WHERE" ] ; then
META_WHERE="s.name in ('$PKG'"
@@ -455,7 +458,7 @@ create_pkg_sets_pages() {
create_pkg_sets_navigation
write_page "<hr />"
META_RESULT=true
- gather_meta_stats $i # FIXME: this ignores unknown packages...
+ gather_meta_stats $i
if $META_RESULT ; then
MAINLABEL[6]="Reproducibility status for packages in $SUITE from '${META_PKGSET[$i]}'"
YLABEL[6]="Amount (${META_PKGSET[$i]} packages)"