From 7f9e498e48c4e5d056ee988a23dedb8ca98b11cd Mon Sep 17 00:00:00 2001
From: Lukas Fleischer <archlinux@cryptocrack.de>
Date: Fri, 11 Mar 2011 18:54:44 +0100
Subject: Fix broken XHTML.

Fix a lot of invalid XHTML in the templates and actions. There might
still be some legacy code left, but this should cover most of it.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
---
 web/template/pkg_details.php | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

(limited to 'web/template/pkg_details.php')

diff --git a/web/template/pkg_details.php b/web/template/pkg_details.php
index 6a624e9..3b96791 100644
--- a/web/template/pkg_details.php
+++ b/web/template/pkg_details.php
@@ -5,23 +5,25 @@ if ($uid == $row["MaintainerUID"] or
 	($atype == "Developer" or $atype == "Trusted User")) {
 
 	$catarr = pkgCategories();
-	$edit_cat = "<form method='POST' action='packages.php?ID=".$pkgid."'>\n";
-	$edit_cat.= "<input type='hidden' name='action' value='do_ChangeCategory'>";
-	$edit_cat.= "Category: ";
+	$edit_cat = "<form method='post' action='packages.php?ID=".$pkgid."'>\n";
+	$edit_cat.= "<p>";
+	$edit_cat.= "<input type='hidden' name='action' value='do_ChangeCategory' />";
+	$edit_cat.= "<span class='f3'>Category:</span> ";
 	$edit_cat.= "<select name='category_id'>\n";
 	foreach ($catarr as $cid => $catname) {
 		$edit_cat.= "<option value='$cid'";
 		if ($cid == $row["CategoryID"]) {
-		    $edit_cat.="selected";
+		    $edit_cat.=" selected='selected'";
 		}
 		$edit_cat.=">".$catname."</option>";
 	}
-	$edit_cat.= "</select>&nbsp;<input type='submit' value='Change category'>";
+	$edit_cat.= "</select>&nbsp;<input type='submit' value='Change category' />";
+	$edit_cat.= "</p>";
 	$edit_cat.= "</form>";
 
 }
 else {
-	$edit_cat = "Category: ".$row['Category'];
+	$edit_cat = "<span class='f3'>Category: " . $row['Category'] . "</span>";
 }
 
 if ($row["SubmitterUID"]) {
@@ -69,8 +71,9 @@ $out_of_date_time = ($row["OutOfDateTS"] == 0) ? $msg : gmdate("r", intval($row[
 	<span class='f3'><?php echo htmlspecialchars($row['Description'], ENT_QUOTES); ?></span>
 	</p>
 
+	<?php echo $edit_cat ?>
+
 	<p>
-	<span class='f3'><?php echo $edit_cat ?></span><br />
 	<span class='f3'><?php echo __('Submitter') .': ' . $submitter ?></span><br />
 	<span class='f3'><?php echo __('Maintainer') .': ' . $maintainer ?></span><br />
 	<span class='f3'><?php echo $votes ?></span>
-- 
cgit v1.2.3-70-g09d2