From 122636cbb6413d67c37ba73bd7014ae0a977d5c4 Mon Sep 17 00:00:00 2001 From: Lukas Fleischer Date: Sat, 5 Apr 2014 19:32:44 +0200 Subject: Refactor pkgbase_comments_count() Signed-off-by: Lukas Fleischer --- web/lib/pkgbasefuncs.inc.php | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) (limited to 'web/lib/pkgbasefuncs.inc.php') diff --git a/web/lib/pkgbasefuncs.inc.php b/web/lib/pkgbasefuncs.inc.php index 3bb07e5..24ce7a9 100644 --- a/web/lib/pkgbasefuncs.inc.php +++ b/web/lib/pkgbasefuncs.inc.php @@ -25,28 +25,26 @@ function pkgbase_categories() { /** * Get the number of non-deleted comments for a specific package base * - * @param string $pkgid The package base ID to get comment count for + * @param string $base_id The package base ID to get comment count for * * @return string The number of comments left for a specific package */ function pkgbase_comments_count($base_id) { - $dbh = DB::connect(); - $base_id = intval($base_id); - if ($base_id > 0) { - $dbh = DB::connect(); - $q = "SELECT COUNT(*) FROM PackageComments "; - $q.= "WHERE PackageBaseID = " . $base_id; - $q.= " AND DelUsersID IS NULL"; + if (!$base_id) { + return null; } - $result = $dbh->query($q); + $dbh = DB::connect(); + $q = "SELECT COUNT(*) FROM PackageComments "; + $q.= "WHERE PackageBaseID = " . $base_id . " "; + $q.= "AND DelUsersID IS NULL"; + $result = $dbh->query($q); if (!$result) { - return; + return null; } - $row = $result->fetch(PDO::FETCH_NUM); - return $row[0]; + return $result->fetchColumn(0); } /** -- cgit v1.2.3-54-g00ecf