From 2c93f0a98f0f6380fd07ea17fd16afa2c6e4925b Mon Sep 17 00:00:00 2001
From: canyonknight <canyonknight@gmail.com>
Date: Sat, 23 Jun 2012 14:40:11 -0400
Subject: Implement token system to fix CSRF vulnerabilities

Specially crafted pages can force authenticated users to unknowingly perform
actions on the AUR website despite being on an attacker's website. This
cross-site request forgery (CSRF) vulnerability applies to all POST data on
the AUR.

Implement a token system using a double submit cookie. Have a hidden form
value on every page containing POST forms. Use the newly added check_token() to
verify the token sent via POST matches the "AURSID" cookie value. Random
nature of the token limits potential for CSRF.

Signed-off-by: canyonknight <canyonknight@gmail.com>
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
---
 web/lib/acctfuncs.inc.php | 1 +
 1 file changed, 1 insertion(+)

(limited to 'web/lib/acctfuncs.inc.php')

diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php
index 9bd6e51..51078b8 100644
--- a/web/lib/acctfuncs.inc.php
+++ b/web/lib/acctfuncs.inc.php
@@ -33,6 +33,7 @@ function display_account_form($UTYPE,$A,$U="",$T="",$S="",
 	print "<input type='hidden' name='Action' value='".$A."' />\n";
 	if ($UID) {
 		print "<input type='hidden' name='ID' value='".$UID."' />\n";
+		print "<input type='hidden' name='token' value='".htmlspecialchars($_COOKIE['AURSID'])."' />\n";
 	}
 	print "</fieldset>";
 	print "<table border='0' cellpadding='0' cellspacing='0' width='80%' style=\"margin:0 auto;\">\n";
-- 
cgit v1.2.3-54-g00ecf


From 50e97446bbcc605768811fee387efe724b84e042 Mon Sep 17 00:00:00 2001
From: canyonknight <canyonknight@gmail.com>
Date: Sat, 14 Jul 2012 13:32:02 -0400
Subject: acctfuncs.inc.php: Make user_suspended() work correctly

Fixes broken account suspension system.

Signed-off-by: canyonknight <canyonknight@gmail.com>
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
---
 web/lib/acctfuncs.inc.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'web/lib/acctfuncs.inc.php')

diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php
index 51078b8..b7c3ee8 100644
--- a/web/lib/acctfuncs.inc.php
+++ b/web/lib/acctfuncs.inc.php
@@ -795,7 +795,7 @@ function user_suspended( $id )
 	$result = db_query($q, $dbh);
 	if ($result) {
 		$row = mysql_fetch_row($result);
-		if ($result[0] == 1 ) {
+		if ($row[0]) {
 			return true;
 		}
 	}
-- 
cgit v1.2.3-54-g00ecf