From d4b07f2b334dada626e4743951cdd6adab87f62e Mon Sep 17 00:00:00 2001
From: Callan Barrett <wizzomafizzo@gmail.com>
Date: Sat, 12 Jan 2008 18:18:43 +0900
Subject: Tweaks of various page layouts and handling of data

This is a patch that fixes a lot of little things:
* We no longer have pkgsearch or pkgdetails link functions and all
references to them are gone, that's what a back button is for and if
we really need it we can come up with something better
* No longer have do_Details variable, this means links on the package
search are simply ?ID=foo
* On the pkgdetails pages when there are either no deps, deps by,
sources or comments for a package the list for each will display
"None" instead of nothing at all (ruining the layout)
* Fixed a bug where if a package had no sources or no deps
pkgsubmit.php would submit an empty one
* Translation of the word "Search'" has been changed to "Search"

Most of these relate to each other.

Signed-off-by: Callan Barrett <wizzomafizzo@gmail.com>
---
 web/html/packages.php | 30 ++----------------------------
 1 file changed, 2 insertions(+), 28 deletions(-)

(limited to 'web/html/packages.php')

diff --git a/web/html/packages.php b/web/html/packages.php
index 9deff6a..bc398ee 100644
--- a/web/html/packages.php
+++ b/web/html/packages.php
@@ -92,9 +92,6 @@ if (isset($_REQUEST["do_Flag"])) {
 			print __("You did not select any packages to flag.");
 			print "</p>\n";
 		}
-
-		pkgsearch_results_link();
-				
 	}
 
 } elseif (isset($_REQUEST["do_UnFlag"])) {
@@ -131,7 +128,6 @@ if (isset($_REQUEST["do_Flag"])) {
 			print "</p>\n";
 		}
 
-		pkgsearch_results_link();
 				
 	}
 
@@ -187,7 +183,6 @@ if (isset($_REQUEST["do_Flag"])) {
 			print "</p>\n";
 		}
 
-		pkgsearch_results_link();
 
 	}
 
@@ -295,7 +290,6 @@ if (isset($_REQUEST["do_Flag"])) {
 			print __("You did not select any packages to delete.");
 			print "</p>\n";
 		} # end if (!empty($ids))
-		pkgsearch_results_link();
 	} # end if (!atype)
 
 } elseif (isset($_REQUEST["do_Adopt"])) {
@@ -353,9 +347,6 @@ if (isset($_REQUEST["do_Flag"])) {
 			print __("You did not select any packages to adopt.");
 			print "</p>\n";
 		}
-
-		pkgsearch_results_link();
-
 	}
 
 
@@ -414,13 +405,6 @@ if (isset($_REQUEST["do_Flag"])) {
 			print __("You did not select any packages to vote for.");
 			print "</p>\n";
 		}
-
-		if (isset($_REQUEST["ID"])) {
-			pkgdetails_link($_REQUEST["ID"]);
-		} else {
-			pkgsearch_results_link();
-		}
-
 	}
 
 
@@ -471,28 +455,19 @@ if (isset($_REQUEST["do_Flag"])) {
 			print __("You did not select any packages to un-vote for.");
 			print "</p>\n";
 		}
-
-		if (isset($_REQUEST["ID"])) {
-			pkgdetails_link($_REQUEST["ID"]);
-		} else {
-			pkgsearch_results_link();
-		}
-
 	}
 
 
-} elseif (isset($_REQUEST["do_Details"])) {
+} elseif (isset($_REQUEST["ID"])) {
 
-	if (!isset($_REQUEST["ID"]) || !intval($_REQUEST["ID"])) {
+	if (!intval($_REQUEST["ID"])) {
 		print __("Error trying to retrieve package details.")."<br />\n";
 		
 	} else {
 		package_details($_REQUEST["ID"], $_COOKIE["AURSID"]);
 	}
 
-	print "<br />\n";
 	# FIXME: If someone hits the detail page's vote button, this link dies
-	pkgsearch_results_link();
 
 } elseif (isset($_REQUEST["do_Notify"])) {
 	# I realize that the implementation here seems a bit convoluted, but we want to
@@ -532,7 +507,6 @@ if (isset($_REQUEST["do_Flag"])) {
 					print '<br /></p>';
 				}
 			}
-			pkgdetails_link($pid);
 		} else {
 			print '<p>';
 			print __("Couldn't add to notification list.");
-- 
cgit v1.2.3-54-g00ecf