From a4ed3a3b3bd4f47cc842e7f909c34f4e41a4655e Mon Sep 17 00:00:00 2001 From: canyonknight Date: Wed, 23 May 2012 13:22:27 -0400 Subject: gendummydata.py: Change variable to string to eliminate redundant code There is no reason the MaintainerUID can't be treated as a string within this script. By changing to a string an "if" statement can be eliminated. Signed-off-by: canyonknight Signed-off-by: Lukas Fleischer --- support/schema/gendummydata.py | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/support/schema/gendummydata.py b/support/schema/gendummydata.py index b7e3110..f996e93 100755 --- a/support/schema/gendummydata.py +++ b/support/schema/gendummydata.py @@ -187,20 +187,14 @@ for p in list(seen_pkgs.keys()): else: muid = trustedusers[random.randrange(0,len(trustedusers))] if count % 20 == 0: # every so often, there are orphans... - muid = 0 + muid = "NULL" uuid = genUID() # the submitter/user - if muid == 0: - s = ("INSERT INTO Packages (ID, Name, Version, CategoryID," - " SubmittedTS, SubmitterUID, MaintainerUID) VALUES" - " (%d, '%s', '%s', %d, %d, %d, NULL);\n") - s = s % (seen_pkgs[p], p, genVersion(), genCategory(), NOW, uuid) - else: - s = ("INSERT INTO Packages (ID, Name, Version, CategoryID," - " SubmittedTS, SubmitterUID, MaintainerUID) VALUES " - " (%d, '%s', '%s', %d, %d, %d, %d);\n") - s = s % (seen_pkgs[p], p, genVersion(), genCategory(), NOW, uuid, muid) + s = ("INSERT INTO Packages (ID, Name, Version, CategoryID," + " SubmittedTS, SubmitterUID, MaintainerUID) VALUES " + " (%d, '%s', '%s', %d, %d, %d, %s);\n") + s = s % (seen_pkgs[p], p, genVersion(), genCategory(), NOW, uuid, muid) out.write(s) count += 1 -- cgit v1.2.3-54-g00ecf