From 3a42725601885af3c7b25b376cd4c141c71968ee Mon Sep 17 00:00:00 2001 From: Loui Chang Date: Tue, 17 Jun 2008 01:03:16 -0400 Subject: Remove all vim mode lines. Add HACKING file. Signed-off-by: Loui Chang --- HACKING | 24 ++++++++++++++++++++++++ web/html/account.php | 2 +- web/html/addvote.php | 1 - web/html/css/arch.css | 3 +-- web/html/css/containers.css | 3 +-- web/html/css/fonts.css | 3 +-- web/html/hacker.php | 2 +- web/html/index.php | 1 - web/html/logout.php | 1 - web/html/packages.php | 2 +- web/html/pkgedit.php | 1 - web/html/pkgsubmit.php | 2 +- web/html/rss2.php | 2 -- web/html/template.php | 6 +----- web/html/testpo.php | 1 - web/html/timeout.php | 2 +- web/html/tu.php | 1 - web/lib/acctfuncs.inc | 1 - web/lib/aur.inc | 1 - web/lib/config.inc.proto | 1 - web/lib/pkgfuncs.inc | 1 - web/lib/translator.inc | 1 - 22 files changed, 33 insertions(+), 29 deletions(-) create mode 100644 HACKING diff --git a/HACKING b/HACKING new file mode 100644 index 0000000..eef0be1 --- /dev/null +++ b/HACKING @@ -0,0 +1,24 @@ +HACKING + +DISCLAIMER: We realise the code doesn't necessarily follow all the rules. +This is an attempt to establish a standard coding style for future +development. + +Coding style guidelines +----------------------- +Column width: 79 columns or less within reason. + +Indentation: tabs (standard eight column width) +Please don't add any mode lines. Adjust your editor to display tabs to your +preferred width. Generally code should work with the standard eight column +tabs. + +Try embedding as little HTML in the PHP as possible. +Consider creating templates for HTML. + +MySQL queries should generally go into functions. + +Please submit uncompressed git-formatted patches to aur-dev@archlinux.org. +When writing patches please keep unnecessary changes to a minimum. +Smaller patches are much easier to review thus have a better chance of being +pushed more quickly into the main repo. diff --git a/web/html/account.php b/web/html/account.php index b46ad55..5efc401 100644 --- a/web/html/account.php +++ b/web/html/account.php @@ -156,5 +156,5 @@ echo " "; echo ""; html_footer(AUR_VERSION); -# vim: ts=2 sw=2 noet ft=php + ?> diff --git a/web/html/addvote.php b/web/html/addvote.php index ef1c6c3..8e4df79 100644 --- a/web/html/addvote.php +++ b/web/html/addvote.php @@ -90,6 +90,5 @@ if ($atype == "Trusted User" OR $atype == "Developer") { } html_footer(AUR_VERSION); -# vim: ts=2 sw=2 noet ft=php ?> diff --git a/web/html/css/arch.css b/web/html/css/arch.css index bdca5ec..9dc630e 100644 --- a/web/html/css/arch.css +++ b/web/html/css/arch.css @@ -452,5 +452,4 @@ textarea.vLargeTextField { border-collapse: separate; border-spacing: 0 15px; } -/* vim:ts=2:sw=2:et:enc=utf-8: - * */ + diff --git a/web/html/css/containers.css b/web/html/css/containers.css index 95a5c45..c0fb877 100644 --- a/web/html/css/containers.css +++ b/web/html/css/containers.css @@ -181,5 +181,4 @@ input.button { font-size: 12px; padding: 2px; } -/* vim:ts=2:sw=2:et:enc=utf-8: - * */ + diff --git a/web/html/css/fonts.css b/web/html/css/fonts.css index ae4b76f..dc65070 100644 --- a/web/html/css/fonts.css +++ b/web/html/css/fonts.css @@ -100,5 +100,4 @@ h1, h2, h3, h4 { font-size: 16pt; } span.important { color: #f00; } -/* vim:ts=2:sw=2:et:enc=utf-8: - * */ + diff --git a/web/html/hacker.php b/web/html/hacker.php index d288a5e..5087c29 100644 --- a/web/html/hacker.php +++ b/web/html/hacker.php @@ -13,5 +13,5 @@ print __("If this problem persists, please contact the site administrator."); print "

\n"; html_footer(AUR_VERSION); -# vim: ts=2 sw=2 noet ft=php + ?> diff --git a/web/html/index.php b/web/html/index.php index d0001eb..7a95abf 100644 --- a/web/html/index.php +++ b/web/html/index.php @@ -236,5 +236,4 @@ endif; diff --git a/web/html/logout.php b/web/html/logout.php index 0b275b8..c1c376c 100644 --- a/web/html/logout.php +++ b/web/html/logout.php @@ -23,5 +23,4 @@ header('Location: index.php'); exit; html_footer(AUR_VERSION); -# vim: ts=2 sw=2 noet ft=php ?> diff --git a/web/html/packages.php b/web/html/packages.php index afee32e..4cfe9c4 100644 --- a/web/html/packages.php +++ b/web/html/packages.php @@ -488,5 +488,5 @@ if ($_POST['action'] == "do_Flag" || isset($_POST['do_Flag'])) { } html_footer(AUR_VERSION); -# vim: ts=2 sw=2 noet ft=php + ?> diff --git a/web/html/pkgedit.php b/web/html/pkgedit.php index 5dbc0a9..610113a 100644 --- a/web/html/pkgedit.php +++ b/web/html/pkgedit.php @@ -170,5 +170,4 @@ print __("You've found a bug if you see this....")."
\n"; html_footer(AUR_VERSION); -# vim: ts=2 sw=2 noet ft=php ?> diff --git a/web/html/pkgsubmit.php b/web/html/pkgsubmit.php index 65706e8..4d15ebe 100644 --- a/web/html/pkgsubmit.php +++ b/web/html/pkgsubmit.php @@ -489,5 +489,5 @@ endif; diff --git a/web/html/rss2.php b/web/html/rss2.php index 9d198cc..1f5c50c 100644 --- a/web/html/rss2.php +++ b/web/html/rss2.php @@ -53,6 +53,4 @@ while ($row = mysql_fetch_assoc($result)) { #save it so that useCached() can find it $rss->saveFeed("RSS2.0","xml/newestpkg.xml",true); -# $Id$ -# vim: ts=2 sw=2 noet ft=php ?> diff --git a/web/html/template.php b/web/html/template.php index 6a158de..11e05e0 100644 --- a/web/html/template.php +++ b/web/html/template.php @@ -15,10 +15,6 @@ html_header(); # print out the HTML header print __("Hi, this is worth reading!")."
\n"; -html_footer(AUR_VERSION); # Use the $Id$ keyword - # NOTE: when checking in a new file, use - # 'svn propset svn:keywords "Id" filename.php' - # to tell svn to expand the "Id" keyword. +html_footer(AUR_VERSION); -# vim: ts=2 sw=2 et ft=php ?> diff --git a/web/html/testpo.php b/web/html/testpo.php index 75da92a..a8a6337 100644 --- a/web/html/testpo.php +++ b/web/html/testpo.php @@ -42,5 +42,4 @@ print __("Hello, again!")."
\n"; print "\n"; print "\n"; -# vim: ts=2 sw=2 et ft=php ?> diff --git a/web/html/timeout.php b/web/html/timeout.php index 96a3e2e..f6df8ea 100644 --- a/web/html/timeout.php +++ b/web/html/timeout.php @@ -13,5 +13,5 @@ print __("Click on the Home link above to log in."); print "

\n"; html_footer(AUR_VERSION); -# vim: ts=2 sw=2 noet ft=php + ?> diff --git a/web/html/tu.php b/web/html/tu.php index 7ddec1a..524e14d 100644 --- a/web/html/tu.php +++ b/web/html/tu.php @@ -447,6 +447,5 @@ if ($atype == "Trusted User" OR $atype == "Developer") { } html_footer(AUR_VERSION); -# vim: ts=2 sw=2 ?> diff --git a/web/lib/acctfuncs.inc b/web/lib/acctfuncs.inc index dc19ccd..bbd6b74 100644 --- a/web/lib/acctfuncs.inc +++ b/web/lib/acctfuncs.inc @@ -785,5 +785,4 @@ function user_is_privileged( $id ) } -# vim: ts=2 sw=2 noet ft=php ?> diff --git a/web/lib/aur.inc b/web/lib/aur.inc index 25c1d71..81ffde2 100644 --- a/web/lib/aur.inc +++ b/web/lib/aur.inc @@ -410,5 +410,4 @@ function uid_from_username($username="") return $row[0]; } -# vim: ts=2 sw=2 noet ft=php ?> diff --git a/web/lib/config.inc.proto b/web/lib/config.inc.proto index 80eba6e..7a0a155 100644 --- a/web/lib/config.inc.proto +++ b/web/lib/config.inc.proto @@ -30,5 +30,4 @@ $SUPPORTED_LANGS = array( # what languages we have translations for "fr" => "Français" ); -# vim: ts=2 sw=2 noet ft=php ?> diff --git a/web/lib/pkgfuncs.inc b/web/lib/pkgfuncs.inc index 46d8061..77b0ab1 100644 --- a/web/lib/pkgfuncs.inc +++ b/web/lib/pkgfuncs.inc @@ -986,5 +986,4 @@ function pkg_search_page($SID="") { return; } -# vim: ts=4 sw=4 et ft=php ?> diff --git a/web/lib/translator.inc b/web/lib/translator.inc index 93be9e5..41ece89 100644 --- a/web/lib/translator.inc +++ b/web/lib/translator.inc @@ -63,5 +63,4 @@ function __() { return $translated; } -# vim: ts=2 sw=2 noet ft=php ?> -- cgit v1.2.3-54-g00ecf