summaryrefslogtreecommitdiffstats
path: root/web/html/pkgsubmit.php
AgeCommit message (Collapse)AuthorFilesLines
2011-01-28Avoid infinite loop in PKGBUILD variable parser (fixes FS#19482).Lukas Fleischer1-9/+17
Improves variable substitution in the PKGBUILD parser a bit to avoid infinite replacement loops when a PKGBUILD contains assigments of the form "foo=${foo[@]}bar". Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2011-01-25Replaced rm_rf() by rm_tree().Lukas Fleischer1-1/+1
Implemented recursive directory deletion in PHP properly without the use of exec(). This improves security, performance and portability and makes the code compatible with PHP's Safe Mode as well as with PHP setups that disable exec() using the "disable_functions" directive. Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2011-01-24Build URLs from package names (fixes FS#15308, FS#19327).Lukas Fleischer1-5/+3
Drop the "URLPath" field from the "Packages" table, build URLs from package names instead. Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2011-01-19Removed code for tarball extraction.Lukas Fleischer1-48/+12
Automatic tarball extraction was vulnerable in different ways. Users should also only use source tarballs to build packages, so this has been removed completely. From now on, only the PKGBUILD is extracted in a secure manner. Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2010-11-10Add timestamp when a package is flagged out-of-date (FS#20848).Lukas Fleischer1-1/+1
Signed-off-by: Loui Chang <louipc.ist@gmail.com> - resolve conflict and omit i18n changes.
2010-06-23pkgsubmit: Remove build function checkAndrea Scarpino1-15/+1
Closes: http://bugs.archlinux.org/task/19914 Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2010-06-05pkgsubmit: store the previous path with getcwd()mickael91-1/+3
This solves the problem of include files not being found after an error. $_SERVER['DOCUMENT_ROOT'] is not reliable because the AUR might be installed in a subdirectory. This closes http://bugs.archlinux.org/task/16887 Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2009-11-24pkgsubmit.php: Remove redundant error message.Loui Chang1-8/+0
Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2009-11-23Restyle the layout.Loui Chang1-0/+5
Make HTML markup more logical. Remove some unused style sheets rules. Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2009-11-09pkgsubmit: Instruct users how to make source packages.Loui Chang1-6/+7
Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2009-09-28Remove the plain PKGBUILD upload feature.Loui Chang1-4/+0
makepkg --source should be used to upload packages. It provides a bit of error checking and it's good to support only a single format here. Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2009-08-11Use include_once where applicableDan McGee1-5/+5
All of these are sourcing function libraries so we don't need to include them more than once. Things that insert actual HTML into the output were left calling include(). Signed-off-by: Dan McGee <dan@archlinux.org> Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2009-06-25Remove excess whitespace.Loui Chang1-6/+6
Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2009-06-18Turn on package notification by default for new packagesCallan Barrett1-0/+3
Version using package functions Signed-off-by: Callan Barrett <wizzomafizzo@gmail.com> Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2009-06-18fix FS#13122 (again): removing comment removal as early as possibleGergely Imreh1-3/+3
comments need to be removed before concatenating lines, otherwise not matched brackets can cause problems on submit Signed-off-by: Gergely Imreh <imrehg@gmail.com> Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2009-04-01Tweak the bash parsing for package submission.Loui Chang1-10/+17
Better detection of the build function. Better detection of variables. Support for variables with underscores. Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2009-02-16Correct comment removal in pkgsubmit.phpGergely Imreh1-4/+7
This only neutralises bash parameter substitution, but doesn't perform the proper replacement. Closes FS#13122. Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2009-02-15Fix: FS#13189, infinite variable replacement cycleGergely Imreh1-1/+5
Lines such as foo=$foo in the PKGBUILD would end up in a infinite replacement cycle when uploaded, thus the upload times out. In these kind of lines, $foo is replaced not by "$foo" again, but deleted (missing value for foo). Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2009-01-28FS#2649, FS#12645: subsititution of all variables and "eval"Gergely Imreh1-11/+26
All custom variables are handled during subsitution, as well as bash "eval" statements. Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2009-01-19Use new conglomerated translation files.Loui Chang1-1/+0
Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2009-01-14Fix: FS#12698 - AUR does not ignore comment lines in PKGBUILD source field.Gergely Imreh1-6/+13
The web interface was handling comments in the PKGBUILD variable fields (such as 'source','depends',etc...) differently from makepkg, because makepkg ignores the rest of the current line if there is a # character, while the web interface parsed that as well, and listed the words of the comment as source files. Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2009-01-08Don't require source or md5sum arrays in PKGBUILDs.Loui Chang1-2/+3
Also fix a translation string. Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2009-01-04Minimize calls to uid_from_sid()Dan McGee1-5/+7
Just like the previous patch for account_from_sid() over-usage. Signed-off-by: Dan McGee <dan@archlinux.org> Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2008-12-29Correct undefined constant error in pkgsubmit.Loui Chang1-4/+6
Clean up a couple of notices. Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2008-12-22Really make all web paths relative.Loui Chang1-1/+1
I forgot about the forms. Signed-off-by: Loui Chang <louipc.ist@gmail.com> Signed-off-by: Callan Barrett <wizzomafizzo@gmail.com>
2008-12-21Introduce function include_lang for translations.Loui Chang1-2/+2
This includes only the requested language for each page and makes top level language include files obsolete. Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2008-12-20Fix PKGBUILD source array parsing.Evangelos Foutras1-1/+3
Fix for FS#11132 - AUR fails to parse multiline source array Signed-off-by: Evangelos Foutras <foutrelis@gmail.com> Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2008-12-20Add error checking to chmod on package submissionCallan Barrett1-1/+1
Try submitting an empty form to the aur Signed-off-by: Callan Barrett <wizzomafizzo@gmail.com> Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2008-11-13Give group writable permissions to uploaded files.Loui Chang1-17/+19
Add a new function chown_group to recursively change permissions. Tweak some of the coding style. Replace some of the redundant string concatenation with a variable. Thanks to Dan McGee for chmod_group. Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2008-11-03Merge branch 'testing'Loui Chang1-142/+123
Conflicts: web/html/pkgsubmit.php Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2008-09-13Fix whitespace and indenting in pkgsubmit.Loui Chang1-117/+112
Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2008-07-28Include File/Find.php PEAR moduleSimo Leone1-2/+2
Since this module requires root to install system-wide, and is somewhat rare, it's better to just include it in the AUR code itself. Signed-off-by: Simo Leone <simo@archlinux.org>
2008-07-09Redirect on package submissionCallan Barrett1-33/+17
On a successful package submit there will be a redirect to the package details page of the packages, no more successful message Also got rid of the $warning stuff, what the hell was that for? Signed-off-by: Callan Barrett <wizzomafizzo@gmail.com> Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2008-06-17Remove all vim mode lines. Add HACKING file.Loui Chang1-1/+1
Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2008-06-15Clean up of pkgsubmit.phpCallan Barrett1-206/+165
Moved some stuff around, rewrote some stuff although the functionality is exactly the same as before Signed-off-by: Callan Barrett <wizzomafizzo@gmail.com>
2008-06-12Make use of PEAR packages in pkgsubmit.phpCallan Barrett1-112/+60
Uses File_Find and Archive_Tar in pkgsubmit.php Removes references to PackageContents Signed-off-by: Callan Barrett <wizzomafizzo@gmail.com>
2008-06-09Fix FS#8622Callan Barrett1-18/+24
Previous fix for this was only half implemented, links now work with both a new package and an updated one Signed-off-by: Callan Barrett <wizzomafizzo@gmail.com>
2008-06-09Fix FS#10016Callan Barrett1-4/+4
Fix entry of URLPath and FSPath to be actual locations, fixes RPC results Signed-off-by: Callan Barrett <wizzomafizzo@gmail.com>
2008-06-07Unmark out-of-date on updateCallan Barrett1-0/+1
What it says in the title Signed-off-by: Callan Barrett <wizzomafizzo@gmail.com>
2008-06-07Support for uploading plain PKGBUILDsCallan Barrett1-5/+9
Adds support for uploading plain PKGBUILDs to the AUR Simply moves the PKGBUILD to a directory to be treated the same as if it were in a tarball Signed-off-by: Callan Barrett <wizzomafizzo@gmail.com>
2008-06-05Don't reset category on update.Callan Barrett1-0/+2
When updating a package and no category is selected the category will no longer reset itself to "none", it will only update if something else is chosen. Signed-off-by: Callan Barrett <wizzomafizzo@gmail.com> Signed-off-by: Loui Chang <louipc.ist@gmail.com>
2008-01-23Removed QBUG and DBUGSimo Leone1-10/+0
It was broken and hardly used. It's just as easy to add short print statements or logging if some debugging output is needed. Signed-off-by: Simo Leone <simo@archlinux.org>
2008-01-20Prefill category upon upload error and fix bug in last patchCallan Barrett1-48/+39
When a package upload fails the category value will be prefilled, fixes a bug in the previous patch where the pkgbuild would not extract properly and splits the html from php in the form so there are no more prints to output it Signed-off-by: Callan Barrett <wizzomafizzo@gmail.com>
2008-01-20Allow pkgsubmit to accept any tar* fileDan McGee1-5/+3
Instead of restricting to gz and bz2, allow just plain tar and any other format tar can understand to be uploaded. I make the mistake all the time of forgetting to pass -z to tar when making something to upload, and there is no real reason to exclude plain tar files. Signed-off-by: Dan McGee <dan@archlinux.org>
2008-01-20Support for verbose page titlesCallan Barrett1-1/+1
Verbose page titles again Adds support for more verbose page titles based on current page and action by user and removes sort by options from search form as they're obsolete by column links. Signed-off-by: Callan Barrett <wizzomafizzo@gmail.com>
2008-01-20Tweaks of various page layouts and handling of dataCallan Barrett1-10/+18
This is a patch that fixes a lot of little things: * We no longer have pkgsearch or pkgdetails link functions and all references to them are gone, that's what a back button is for and if we really need it we can come up with something better * No longer have do_Details variable, this means links on the package search are simply ?ID=foo * On the pkgdetails pages when there are either no deps, deps by, sources or comments for a package the list for each will display "None" instead of nothing at all (ruining the layout) * Fixed a bug where if a package had no sources or no deps pkgsubmit.php would submit an empty one * Translation of the word "Search'" has been changed to "Search" Most of these relate to each other. Signed-off-by: Callan Barrett <wizzomafizzo@gmail.com>
2008-01-20Removes need for name, overwrite and comment fields from pkgsubmit.phpCallan Barrett1-192/+115
This removes the name, overwrite and comment options from pkgsubmit.php by moving when the tarball is extracted (and where) and when the pkgbuild is parsed so pkgname is taken from the pkgbuild instead of user input Signed-off-by: Callan Barrett <wizzomafizzo@gmail.com>
2008-01-20Bug in uploading PKGBUILDs and aur schemaCallan Barrett1-3/+0
This fixes a bug where TUs and devs couldn't upload packages because the query would have an extra column in it to mark the pkgbuild safe automatically, guessing it got missed when the safe flags were removed. Also fixes a screw up I made with the schema file when I added the tables for the voting app. Signed-off-by: Callan Barrett <wizzomafizzo@gmail.com>
2008-01-20Hand diff of simo's patch to remove flag safe functionality.eliott1-8/+0
Simo's original commit text: The idea of safe flagging is unclear, poorly named, misunderstood, and not even used. At the time this patch was created, less than a third of the packages in unsupported were flagged safe, and less than a tenth of users knew how to interpret it. The safe flag has been replaced by a disclaimer on the main page.
2007-10-02Fixed version strings.tardo1-1/+1
Added AUR_VERSION to config file, so now we should only need to change one location. KISS ftw. Signed-off-by: tardo <tardo@nagi-fanboi.net>