summaryrefslogtreecommitdiffstats
path: root/web/html
diff options
context:
space:
mode:
authorDan McGee <dan@archlinux.org>2011-04-25 23:23:01 -0500
committerLukas Fleischer <archlinux@cryptocrack.de>2011-04-27 14:50:27 +0200
commit3609cf140eaca30878d0a69fba0d837b4fec41a0 (patch)
tree5132be13c5b5afb70c7d281c6220f9fb5cbbcf2a /web/html
parentfcda6671f3021273844f7898c7cfec1e99df8ec2 (diff)
downloadaurweb-3609cf140eaca30878d0a69fba0d837b4fec41a0.tar.xz
SQL: treat all UID/ID values as numbers, not strings
Ensure we are not quoting these values in any of our SQL queries. Thanks-to: elij <elij.mx@gmail.com> Signed-off-by: Dan McGee <dan@archlinux.org> Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
Diffstat (limited to 'web/html')
-rw-r--r--web/html/passreset.php4
-rw-r--r--web/html/pkgsubmit.php2
2 files changed, 3 insertions, 3 deletions
diff --git a/web/html/passreset.php b/web/html/passreset.php
index 2c7801d..0ce6f7d 100644
--- a/web/html/passreset.php
+++ b/web/html/passreset.php
@@ -58,8 +58,8 @@ if (isset($_GET['resetkey'], $_POST['email'], $_POST['password'], $_POST['confir
$resetkey = new_sid();
$dbh = db_connect();
$q = "UPDATE Users
- SET ResetKey = '$resetkey'
- WHERE ID = '$uid'";
+ SET ResetKey = '" . $resetkey . "'
+ WHERE ID = " . $uid;
db_query($q, $dbh);
# Send email with confirmation link
$body = __('A password reset request was submitted for the account '.
diff --git a/web/html/pkgsubmit.php b/web/html/pkgsubmit.php
index f2777b7..26608ea 100644
--- a/web/html/pkgsubmit.php
+++ b/web/html/pkgsubmit.php
@@ -325,7 +325,7 @@ if ($uid):
}
# Update package data
- $q = sprintf("UPDATE Packages SET ModifiedTS = UNIX_TIMESTAMP(), Name = '%s', Version = '%s-%s', License = '%s', Description = '%s', URL = '%s', OutOfDateTS = NULL, MaintainerUID = '%d' WHERE ID = %d",
+ $q = sprintf("UPDATE Packages SET ModifiedTS = UNIX_TIMESTAMP(), Name = '%s', Version = '%s-%s', License = '%s', Description = '%s', URL = '%s', OutOfDateTS = NULL, MaintainerUID = %d WHERE ID = %d",
mysql_real_escape_string($new_pkgbuild['pkgname']),
mysql_real_escape_string($new_pkgbuild['pkgver']),
mysql_real_escape_string($new_pkgbuild['pkgrel']),