diff options
author | Dan McGee <dan@archlinux.org> | 2011-04-12 00:15:47 -0500 |
---|---|---|
committer | Lukas Fleischer <archlinux@cryptocrack.de> | 2011-04-16 17:47:57 +0200 |
commit | aa206b343af8821e01c4984ae27ab510b87a43e8 (patch) | |
tree | 5c35c8910118f76b97ffec3e9154c300bfb1f16e /HACKING | |
parent | 8fdb382d67ef1c5af3b63d0309f450e025d06868 (diff) | |
download | aurweb-aa206b343af8821e01c4984ae27ab510b87a43e8.tar.xz |
rpc.php overhaul
* Mark things static in the class rather than use a constructor every
single invocation of the service.
* Don't call mysql_real_escape_string() before we even have a database
connection, and don't do work in the database if we don't need to.
* Formatting consistency fixups in a few places.
* Add new process_query() helper function; use this instead of
copy-pasted code in all of the RPC method calls.
* Remove the escaping code meant to fix FS#15526, introduced in commit
4d1eb4dd7ac631. It broke more than it solved, only fixed the output in
one of three RPC calls (and who knows what the web interface then also
does), and proper encoding should be done at the database level rather
than up here.
Lukas: Add special case for "info" queries to process_query() (return a
single result instead of an array of results here).
Signed-off-by: Dan McGee <dan@archlinux.org>
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
Diffstat (limited to 'HACKING')
0 files changed, 0 insertions, 0 deletions